Improvements on rbtree_best_fit::check_sanity - #282
Merged
Conversation
13 tasks
Perform quick tests before iterating on the blocks. Early exit from loop if block size is 0 or accumulated free memory exceeds maximum. Signed-off-by: Miguel Company <miguelcompany@eprosima.com>
MiguelCompany
force-pushed
the
improve_check_sanity
branch
from
August 12, 2026 10:29
461fe71 to
f1b8b27
Compare
Member
|
Many thanks for the contribution. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When checking the sanity of a shared memory segment, if the memory has been corrupted, the iterator might read outside the segment, producing a segfault.
This was found during the investigation of eProsima/Fast-DDS#6501
The proposed changes perform the quick check on the header before the loop.
Inside the loop, the check for the alignment is performed before accessing the data pointed to by the iterator, and the loop returns early whenever the accumulated
free_memoryvalue exceeds the limit.This reduces the chance of the iterator jumping to an offset outside the segment.